It is currently Thu Nov 21, 2019 10:49 pm

All times are UTC - 8 hours [ DST ]




Post new topic Reply to topic  [ 24 posts ] 
Author Message
PostPosted: Wed Jul 03, 2013 12:08 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Windows 7.0


Windows 8.1


Last edited by Seryi on Mon Jul 08, 2013 11:33 am, edited 1 time in total.

Top
 Profile  
Reply with quote  
PostPosted: Wed Jul 03, 2013 6:21 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
I don't see a difference. Can you provide side by side screenshot (but as PNG, not GIF).


Top
 Profile  
Reply with quote  
PostPosted: Wed Jul 03, 2013 11:26 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Some icons: Windows 7 Windows 7 + CS Windows 8.1 + CS
Documents
Computer
Printers


Top
 Profile  
Reply with quote  
PostPosted: Thu Jul 04, 2013 6:42 am 
Offline
User avatar

Joined: Sun Jan 06, 2013 1:44 pm
Posts: 1982
Im guessing windows uses 128x128 images for those icons in windows 7?, whereas windows 8 only has up to 64x64 pixel icons correct?


Top
 Profile  
Reply with quote  
PostPosted: Thu Jul 04, 2013 7:12 am 
Offline
User avatar

Joined: Thu Jan 03, 2013 12:38 am
Posts: 5352
In Windows 8 RTM, I see properly resized icons. I haven't tried 8.1. Have MS stripped the 256 x 256 images from the icons in imageres.dll?

_________________
Links to some general topics:

Compare Start Menus

Read the Search box usage guide.

I am a Windows enthusiast and helped a little with Classic Shell's testing and usability/UX feedback.


Top
 Profile  
Reply with quote  
PostPosted: Sat Jul 06, 2013 9:20 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Original Windows 7 menu uses different icons for different settings for the screen size (100%, 125%, 150%), which correspond to these dimensions (for example, a document icon have different number of strips). CS does not increase the icons when you zoom the screen controls.


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 9:04 pm 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
This looks like a bug in Windows. The icons in imageres.dll are fine, but the new implementation of IShellItemImageFactory seems to be loading them incorrectly. The most obvious error is in the Control Panel icon. Parts if it are completely missing.

I will run some tests and may have to create an example for Microsoft to reproduce the problem.


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 10:10 pm 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
May be - then use ICO instead of PNG?


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 11:28 pm 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
If you manually set the icon in the settings it will work. The problem is if you have a link like Control Panel and then I have to get the icon using the API. Then it is corrupted.


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 11:37 pm 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
I mean - to make reference to the ICO instead of PNG - as in the file imageres.dll images are duplicated in different formats.


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 11:41 pm 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
I am not referencing anything. I am asking the OS to give me the image for the folder (like Control Panel). That's where it is failing.
If you manually select the icon in the start menu settings (like imageres.dll,27) then it looks OK. Because it is being loaded by my own code.


Top
 Profile  
Reply with quote  
PostPosted: Sun Jul 07, 2013 11:54 pm 
Offline
User avatar

Joined: Thu Jan 03, 2013 12:38 am
Posts: 5352
Is IShellItemImageFactory the only interface for that or the legacy IExtractIcon will also work?

_________________
Links to some general topics:

Compare Start Menus

Read the Search box usage guide.

I am a Windows enthusiast and helped a little with Classic Shell's testing and usability/UX feedback.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 12:03 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
IExtractIcon can only reliably get icons of standard sizes. Doesn't work for larger icons.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 12:24 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Ivo wrote:
I will run some tests and may have to create an example for Microsoft to reproduce the problem.


Maybe then they will have time fixed a problem in the final version, if hurry.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 12:46 am 
Offline
User avatar

Joined: Thu Jan 03, 2013 12:38 am
Posts: 5352
But the DPI problem is there on Windows 7/8.0 too. When the DPI/PPI is increased, the icon doesn't get larger like the Windows 7 menu's icon does due to this bug in IShellItemImageFactory interface?

_________________
Links to some general topics:

Compare Start Menus

Read the Search box usage guide.

I am a Windows enthusiast and helped a little with Classic Shell's testing and usability/UX feedback.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 8:13 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
No. I have decided to make the size DPI-independent for two reasons - First, the skin needs only one picture frame, not 3 or 4 like the Aero theme, and Second, I don't want to depend on icons having a larger image than 64x64.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 8:32 am 
Offline
User avatar

Joined: Thu Jan 03, 2013 12:38 am
Posts: 5352
But why 64 x 64? Then there should have been one big 256 x 256 user frame which gets shrunk and the icons too.

_________________
Links to some general topics:

Compare Start Menus

Read the Search box usage guide.

I am a Windows enthusiast and helped a little with Classic Shell's testing and usability/UX feedback.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 8:35 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
Images work best at their native size, without any shrinking shenanigans. Since most people run 96 DPI, they will always see a shrunken image.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 9:17 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Something is amiss ... If you look at the imageres.dll using MultiExtractor - that there is only a 256x256 PNG ... Then what is the point in the 64x64?


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 9:38 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
The icons in imageres.dll contain multiple sizes and formats - from 16x16 with 2-bit colors to 256x256 with 32-bit colors. I think the highest resolution is stored as PNG and the lower are BMPs (or something similar).


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 10:23 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
MultiExtractor can easy extract resources. There are only 2 formats - ICO (up to 256x256) and 256x256 PNG. As seems from my table above - original Windows 7 get not scaled images, CS - scaled from 256x256 (Win 7 documents). Then may be enable scaling and for 125% screen trimming?


Attachments:
File comment: Extracted from Win7 imageres.dll
DocumentsICO.zip [110.26 KiB]
Downloaded 307 times
Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 10:57 am 
Offline
Site Admin
User avatar

Joined: Wed Jan 02, 2013 11:38 pm
Posts: 5333
The problem is not extracting images from imageres.dll. I can do that. The problem is extracting the correct image for a given folder (like Control Panel). The API for that is "hey, Windows, give me the image for this folder". That's the buggy part. In some cases I can work around it, but in some cases I cannot.


Top
 Profile  
Reply with quote  
PostPosted: Mon Jul 08, 2013 11:26 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
Now look at all those icons - most likely in the Windows 8.1 icons are displayed in 8 bpp color instead of 32 bpp, so the control panel icon with a white stripe at the bottom.


Top
 Profile  
Reply with quote  
PostPosted: Wed Jul 17, 2013 3:43 am 
Offline

Joined: Sat Jan 26, 2013 4:21 am
Posts: 60
In latest build - fixed.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 24 posts ] 

All times are UTC - 8 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group, Almsamim WYSIWYG Classic Shell © 2010-2016, Ivo Beltchev.
All right reserved.